Conversation
jrouly
commented
Mar 2, 2024
jrouly
commented
Mar 2, 2024
Contributor
|
@HonahX since you're more familiar with Glue, would you be able to do this review? :) |
HonahX
reviewed
Mar 2, 2024
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
Overall LGTM! Thanks for working on this! @jrouly I like the way of using Event System to support the catalog id. Just have some small comments.
Contributor
Author
|
@HonahX appreciate the review! Pushed a new commit with your suggestions. |
HonahX
approved these changes
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream Iceberg documentation details
glue.idas a parameter which can be used to set the AWS Glue Catalog ID (AWS Account ID).This is critical for scenarios where the Glue catalog exists in a separate environment from the workload running pyiceberg (e.g. an account separation between workloads and data lake).
This PR reads
glue.idand, if set, injectsCatalogId=as a parameter on all boto3 Glue service calls.